-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metrics: bump prometheus client and use new go collector #35017
Conversation
Signed-off-by: zyguan <zhongyangguan@gmail.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/222fd394f8a08736df70524d9229528bbcd23813 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: e4e8b22
|
TiDB MergeCI notify
|
What problem does this PR solve?
Issue Number: close #35016
Problem Summary: as described in #35016.
What is changed and how it works?
Bump prometheus client to v1.12.2 and use the new go collector. This PR also updates related exprs used in grafana (except for TiDB Runtime, I'm going to make some enhancement on it later). For backward compatibility, the collector is created with
collectors.GoRuntimeMemStatsCollection
option for now, and it might be deprecated later.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.