Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning failed to connect to tidb when using ipv6 host #35880

Closed
D3Hunter opened this issue Jul 1, 2022 · 1 comment · Fixed by #35881
Closed

lightning failed to connect to tidb when using ipv6 host #35880

D3Hunter opened this issue Jul 1, 2022 · 1 comment · Fixed by #35881
Labels
affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects 5.4.x versions. affects-6.1 component/lightning This issue is related to Lightning of TiDB. severity/minor type/bug The issue is confirmed as a bug.

Comments

@D3Hunter
Copy link
Contributor

D3Hunter commented Jul 1, 2022 •
edited
Loading

Bug Report

like pingcap/tiflow#6135, we should use net.JoinHostPort in:

tidb/br/pkg/lightning/common/util.go

Line 60 in ea5b0ff

dsn := fmt.Sprintf("%s:%s@tcp(%s:%d)/?charset=utf8mb4&sql_mode='%s'&maxAllowedPacket=%d&tls=%s",

PS: we cannot workaround by add square brace to host since when connecting to tidb status port we uses net.JoinHostPort, in which case it'll add square brace twice

tidb/br/pkg/lightning/config/config.go

Line 157 in 323411d

hostPort := net.JoinHostPort(cfg.TiDB.Host, strconv.Itoa(cfg.TiDB.StatusPort))

1. Minimal reproduce step (Required)

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiDB version? (Required)
@D3Hunter D3Hunter added type/bug The issue is confirmed as a bug. component/lightning This issue is related to Lightning of TiDB. affects-5.2 This bug affects 5.2.x versions. affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects 5.4.x versions. affects-6.1 and removed affects-5.2 This bug affects 5.2.x versions. affects-5.3 This bug affects 5.3.x versions. labels Jul 1, 2022
@D3Hunter D3Hunter mentioned this issue Jul 1, 2022
Merged
12 tasks
@sleepymole sleepymole changed the title failed to connect to tidb when using ipv6 host lightning failed to connect to tidb when using ipv6 host Jul 1, 2022
ti-chi-bot pushed a commit that referenced this issue Jul 5, 2022
@D3Hunter
lightning: fix ipv6 address (#35881)
673f336 
close #35880
This was referenced Jul 5, 2022
Merged
Merged
Merged
@D3Hunter D3Hunter reopened this Jul 6, 2022
ti-chi-bot pushed a commit that referenced this issue Jul 11, 2022
@ti-srebot
lightning: fix ipv6 address (#35881) (#35932)
7b72995 
close #35880
ti-chi-bot pushed a commit that referenced this issue Jul 11, 2022
@ti-srebot
lightning: fix ipv6 address (#35881) (#35930)
91f4ca2 
close #35880
ti-chi-bot pushed a commit that referenced this issue Jul 11, 2022
@ti-srebot
lightning: fix ipv6 address (#35881) (#35931)
5226a19 
close #35880
@D3Hunter
Copy link
Contributor Author

closed since all cp merged

This was referenced Aug 29, 2022
Merged
Merged
@niubell niubell closed this as completed Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects 5.4.x versions. affects-6.1 component/lightning This issue is related to Lightning of TiDB. severity/minor type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

lightning: fix ipv6 address D3Hunter/tidb
2 participants
@D3Hunter @niubell