Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning: fix ipv6 address (#35881) #35930

Merged
merged 2 commits into from
Jul 11, 2022
Merged

lightning: fix ipv6 address (#35881) #35930

merged 2 commits into from
Jul 11, 2022

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jul 5, 2022 •
edited
Loading

cherry-pick #35881 to release-5.3
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/35930

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/35930:release-5.3-673f336cf1e9

What problem does this PR solve?

Issue Number: close #35880

Problem Summary:

What is changed and how it works?

see issue description

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

fix connect to tidb when using ipv6 host

@D3Hunter @ti-srebot
cherry pick pingcap#35881 to release-5.3
6ff9b52 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 5, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • buchuitoudegou
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 5, 2022
@ti-chi-bot ti-chi-bot removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 5, 2022
@VelocityLight VelocityLight added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 5, 2022
@ti-srebot ti-srebot mentioned this pull request Jul 5, 2022
Merged
12 tasks
@ti-srebot ti-srebot added component/lightning This issue is related to Lightning of TiDB. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/5.3-cherry-pick labels Jul 5, 2022
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 5, 2022
@ti-srebot ti-srebot added this to the v5.3.1 milestone Jul 5, 2022
@ti-srebot
Copy link
Contributor Author

@D3Hunter please accept the invitation then you can push to the cherry-pick pull requests. Comment with /cherry-pick-invite if the invitation is expired.
https://github.com/ti-srebot/tidb/invitations

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 5, 2022
@D3Hunter
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@D3Hunter: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot removed the status/LGT1 Indicates that a PR has LGTM 1. label Jul 11, 2022
@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Jul 11, 2022
@D3Hunter
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6ff9b52

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 11, 2022
@D3Hunter
Copy link
Contributor

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 11, 2022
@lance6716
Copy link
Contributor

/hold

@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed status/can-merge Indicates a PR has been approved by a committer. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 11, 2022
@D3Hunter
Copy link
Contributor

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 11, 2022
@D3Hunter
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3c225de

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 11, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 11, 2022

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/3c225deabcb64ab58caf42b1cb9aadb614c691ec

@D3Hunter
Copy link
Contributor

/run-mysql-test

@ti-chi-bot ti-chi-bot merged commit 91f4ca2 into pingcap:release-5.3 Jul 11, 2022
@D3Hunter D3Hunter deleted the release-5.3-673f336cf1e9 branch July 11, 2022 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sleepymole sleepymole sleepymole left review comments

@buchuitoudegou buchuitoudegou buchuitoudegou approved these changes

@lance6716 lance6716 lance6716 approved these changes

@niubell niubell Awaiting requested review from niubell

Assignees

@D3Hunter D3Hunter

Labels
cherry-pick-approved Cherry pick PR approved by release team. component/lightning This issue is related to Lightning of TiDB. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.3-cherry-pick
Projects
None yet
Milestone
v5.3.1
Development

Successfully merging this pull request may close these issues.
8 participants
@ti-srebot @ti-chi-bot @D3Hunter @lance6716 @sre-bot @sleepymole @buchuitoudegou @VelocityLight