Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br log start failed with start-ts which is from the format of log start --help #36717

Closed
MoCuishle28 opened this issue Jul 29, 2022 · 3 comments · Fixed by #36713
Closed

br log start failed with start-ts which is from the format of log start --help #36717

MoCuishle28 opened this issue Jul 29, 2022 · 3 comments · Fixed by #36713
Labels
affects-6.2 component/br This issue is related to BR of TiDB. severity/moderate type/bug The issue is confirmed as a bug.

Comments

@MoCuishle28
Copy link
Contributor

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

  1. Run br log start --help
  2. Run `br log start --pd 'IP:Port' --task-name pitr --start-ts '2022-07-29 12:00:00'

2. What did you expect to see? (Required)

log start should succeed.

3. What did you see instead (Required)

Error: must set timezone when using datetime format ts

4. What is your TiDB version? (Required)

6.2 nightly
@MoCuishle28 MoCuishle28 added the type/bug The issue is confirmed as a bug. label Jul 29, 2022
@MoCuishle28
Copy link
Contributor Author

/component br

@ti-chi-bot ti-chi-bot added the component/br This issue is related to BR of TiDB. label Jul 29, 2022
@MoCuishle28 MoCuishle28 mentioned this issue Jul 29, 2022
Merged
9 tasks
@MoCuishle28
Copy link
Contributor Author

PR #36713 has fixed this issue.

@3pointer 3pointer reopened this Jul 29, 2022
ti-chi-bot pushed a commit that referenced this issue Jul 29, 2022
@MoCuishle28
log-backup: format the date displayed in --help (#36713)
90e9b63 
close #36717
@ti-srebot ti-srebot mentioned this issue Jul 29, 2022
Merged
9 tasks
ti-chi-bot pushed a commit that referenced this issue Jul 30, 2022
@ti-srebot
log-backup: format the date displayed in --help (#36713) (#36730)
a399181 
close #36717
@3pointer
Copy link
Contributor

3pointer commented Aug 4, 2022

it's better to give an example in error message.

@MoCuishle28 MoCuishle28 mentioned this issue Aug 4, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Aug 18, 2022
@MoCuishle28
br: add an example in timezone-check error message (#36895)
14f9b04 
ref #36717
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.2 component/br This issue is related to BR of TiDB. severity/moderate type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

log-backup: format the date displayed in --help MoCuishle28/tidb
3 participants
@3pointer @MoCuishle28 @ti-chi-bot