Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log-backup: format the date displayed in --help #36713

Merged
merged 5 commits into from
Jul 29, 2022

Conversation

MoCuishle28
Copy link
Contributor

@MoCuishle28 MoCuishle28 commented Jul 29, 2022

Signed-off-by: zhanggaoming gaoming.zhang@pingcap.com

What problem does this PR solve?

Issue Number: close #36717

Problem Summary:
Dates displayed in --help do not have time zone info.

What is changed and how it works?

Add the time zone info in date displayed in --help.
i.e., '2018-05-11 01:42:23' -> '2018-05-11 01:42:23+0800'

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Manual Test

  1. Run ./br log start --help
  2. Run ./br log truncate --help
  3. Run ./br restore point --help

output:
1.

--start-ts string    usually equals last full backupTS, used for backup log. Default value is current ts.
                           support TSO or datetime, e.g. '400036290571534337' or '2018-05-11 01:42:23+0800'.
--until string   Remove all backup data until this TS.(support TSO or datetime, e.g. '400036290571534337' or '2018-05-11 01:42:23+0800'.)
--restored-ts string           the point of restore, used for log restore.
                                     support TSO or datetime, e.g. '400036290571534337' or '2018-05-11 01:42:23+0800'
--start-ts string              the start timestamp which log restore from.
                                     support TSO or datetime, e.g. '400036290571534337' or '2018-05-11 01:42:23+0800'

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: zhanggaoming <gaoming.zhang@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 29, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • YuJuncen

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 29, 2022
@MoCuishle28
Copy link
Contributor Author

/component br

@ti-chi-bot ti-chi-bot added the component/br This issue is related to BR of TiDB. label Jul 29, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 29, 2022

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 29, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 29, 2022
@joccau
Copy link
Member

joccau commented Jul 29, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 32dd2d6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 29, 2022
@joccau joccau added needs-cherry-pick-6.2 and removed status/can-merge Indicates a PR has been approved by a committer. labels Jul 29, 2022
@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 29, 2022
@3pointer 3pointer added skip-issue-check Indicates that a PR no need to check linked issue. and removed do-not-merge/needs-linked-issue labels Jul 29, 2022
@3pointer
Copy link
Contributor

/run-mysql-tests

@joccau
Copy link
Member

joccau commented Jul 29, 2022

/run-mysql-test

@3pointer 3pointer removed the skip-issue-check Indicates that a PR no need to check linked issue. label Jul 29, 2022
@3pointer
Copy link
Contributor

/run-mysql-tests

@3pointer
Copy link
Contributor

/run-mysql-tests

1 similar comment
@3pointer
Copy link
Contributor

/run-mysql-tests

@ti-chi-bot ti-chi-bot merged commit 90e9b63 into pingcap:master Jul 29, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 29, 2022
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-6.2 in PR #36730

@sre-bot
Copy link
Contributor

sre-bot commented Jul 29, 2022

TiDB MergeCI notify

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🟢 all 36 tests passed 30 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 22 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 19 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 41 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 6 min 14 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 50 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 25 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 16 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 47 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/br This issue is related to BR of TiDB. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

br log start failed with start-ts which is from the format of log start --help
7 participants