Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global index: drop global index or drop table but not delete global index range #40953

Closed
L-maple opened this issue Feb 1, 2023 · 7 comments
Closed
Assignees
Labels
feature/developing the related feature is in development severity/minor sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.

Comments

@L-maple
Copy link
Contributor

L-maple commented Feb 1, 2023

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

I find the bug by debugging. I haven't find a way to show deleted regions correctly, because delete index is async.
when ddl is in onDropIndex reorg state, delete global index means partitionIDs should be nil, like the following. Otherwise, the logic would try to delete partitions'

2. What did you expect to see? (Required)

dropping global index / drop table, but not delete global index range.

3. What did you see instead (Required)

dropping global index delete table partitions' index.

4. What is your TiDB version? (Required)

master

| Release Version: v6.6.0-alpha-290-g6676ca816-dirty
Edition: Community
Git Commit Hash: 6676ca8
Git Branch: local/fix_drop_global_index_master
UTC Build Time: 2023-02-01 09:01:32
GoVersion: go1.19.4
Race Enabled: false
TiKV Min Version: 6.2.0-alpha
Check Table Before Drop: false
Store: unistore |

@L-maple L-maple added the type/bug The issue is confirmed as a bug. label Feb 1, 2023
@ChenPeng2013 ChenPeng2013 added the sig/sql-infra SIG: SQL Infra label Feb 2, 2023
@L-maple
Copy link
Contributor Author

L-maple commented Feb 2, 2023

/label severity/minor

@ti-chi-bot
Copy link
Member

@L-maple: The label(s) severity/minor cannot be applied. These labels are supported: fuzz/sqlancer, challenge-program, compatibility-breaker, first-time-contributor, contribution, require-LGT3, good first issue, correctness, duplicate, proposal, security, needs-more-info, needs-cherry-pick-release-4.0, needs-cherry-pick-release-5.0, needs-cherry-pick-release-5.1, needs-cherry-pick-release-5.2, needs-cherry-pick-release-5.3, needs-cherry-pick-release-5.4, needs-cherry-pick-release-6.0, needs-cherry-pick-release-6.1, needs-cherry-pick-release-6.2, needs-cherry-pick-release-6.3, needs-cherry-pick-release-6.4, needs-cherry-pick-release-6.5, affects-4.0, affects-5.0, affects-5.1, affects-5.2, affects-5.3, affects-5.4, affects-6.0, affects-6.1, affects-6.2, affects-6.3, affects-6.4, affects-6.5, may-affects-4.0, may-affects-5.0, may-affects-5.1, may-affects-5.2, may-affects-5.3, may-affects-5.4, may-affects-6.0, may-affects-6.1, may-affects-6.2, may-affects-6.3, may-affects-6.4, may-affects-6.5.

In response to this:

/label severity/minor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@L-maple L-maple changed the title global index: drop global index not take effect global index: drop global index or drop table but not delete global index range Feb 2, 2023
@L-maple
Copy link
Contributor Author

L-maple commented Feb 2, 2023

/assign @L-maple

@Defined2014 Defined2014 added the feature/developing the related feature is in development label May 6, 2023
@Defined2014
Copy link
Contributor

Defined2014 commented May 6, 2023

Hi @L-maple, is this issue fixed? I think it be fixed by #41197, maybe we could close it.

@L-maple
Copy link
Contributor Author

L-maple commented May 6, 2023

@Defined2014 Yes, the issue can be closed~ /close

@L-maple
Copy link
Contributor Author

L-maple commented May 6, 2023

/close

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 6, 2023

@L-maple: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot closed this as completed May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/developing the related feature is in development severity/minor sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants