Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: fix drop global index or drop table but not delete global index range #40954

Closed
wants to merge 1 commit into from
Closed

ddl: fix drop global index or drop table but not delete global index range #40954

wants to merge 1 commit into from

Conversation

L-maple
Copy link
Contributor

@L-maple L-maple commented Feb 1, 2023

What problem does this PR solve?

Issue Number: close #40953

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. labels Feb 1, 2023
@sre-bot
Copy link
Contributor

sre-bot commented Feb 1, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Feb 1, 2023
@ti-chi-bot
Copy link
Member

Hi @L-maple. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@L-maple
Copy link
Contributor Author

L-maple commented Feb 1, 2023

/assign @tiancaiamao

@L-maple L-maple force-pushed the bugfix/fix_drop_global_index_master branch from eacab96 to 96ca95b Compare February 1, 2023 11:02
@L-maple
Copy link
Contributor Author

L-maple commented Feb 1, 2023

/assign @L-maple

@L-maple L-maple changed the title fix(ddl): drop global index not take effect ddl: drop global index not take effect Feb 2, 2023
@L-maple
Copy link
Contributor Author

L-maple commented Feb 2, 2023

/cc @mjonss

@ti-chi-bot ti-chi-bot requested a review from mjonss February 2, 2023 06:25
@L-maple
Copy link
Contributor Author

L-maple commented Feb 2, 2023

/label severity/minor

@ti-chi-bot
Copy link
Member

@L-maple: The label(s) severity/minor cannot be applied. These labels are supported: fuzz/sqlancer, challenge-program, compatibility-breaker, first-time-contributor, contribution, require-LGT3, good first issue, correctness, duplicate, proposal, security, needs-more-info, needs-cherry-pick-release-4.0, needs-cherry-pick-release-5.0, needs-cherry-pick-release-5.1, needs-cherry-pick-release-5.2, needs-cherry-pick-release-5.3, needs-cherry-pick-release-5.4, needs-cherry-pick-release-6.0, needs-cherry-pick-release-6.1, needs-cherry-pick-release-6.2, needs-cherry-pick-release-6.3, needs-cherry-pick-release-6.4, needs-cherry-pick-release-6.5, affects-4.0, affects-5.0, affects-5.1, affects-5.2, affects-5.3, affects-5.4, affects-6.0, affects-6.1, affects-6.2, affects-6.3, affects-6.4, affects-6.5, may-affects-4.0, may-affects-5.0, may-affects-5.1, may-affects-5.2, may-affects-5.3, may-affects-5.4, may-affects-6.0, may-affects-6.1, may-affects-6.2, may-affects-6.3, may-affects-6.4, may-affects-6.5.

In response to this:

/label severity/minor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@L-maple L-maple force-pushed the bugfix/fix_drop_global_index_master branch from 96ca95b to 315070e Compare February 2, 2023 07:39
@L-maple L-maple changed the title ddl: drop global index not take effect ddl: drop global index / drop table but not delete global index range Feb 2, 2023
@L-maple L-maple changed the title ddl: drop global index / drop table but not delete global index range ddl: fix drop global index or drop table but not delete global index range Feb 2, 2023
@L-maple L-maple force-pushed the bugfix/fix_drop_global_index_master branch from 315070e to 599a327 Compare February 2, 2023 07:43
@L-maple
Copy link
Contributor Author

L-maple commented Feb 8, 2023

I will propose a new PR, which contains this PR. So close it.

@L-maple
Copy link
Contributor Author

L-maple commented Feb 8, 2023

/close

@ti-chi-bot ti-chi-bot closed this Feb 8, 2023
@ti-chi-bot
Copy link
Member

@L-maple: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjonss mjonss Awaiting requested review from mjonss

Assignees

@tiancaiamao tiancaiamao

@L-maple L-maple

Labels
needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

global index: drop global index or drop table but not delete global index range
4 participants
@L-maple @ti-chi-bot @sre-bot @tiancaiamao