Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If multiple TiDBs are upgraded concurrently, the upgrade may block. #46228

Closed
zimulala opened this issue Aug 18, 2023 · 0 comments · Fixed by #46234
Closed

If multiple TiDBs are upgraded concurrently, the upgrade may block. #46228

zimulala opened this issue Aug 18, 2023 · 0 comments · Fixed by #46234
Assignees
@zimulala
Labels
affects-7.1 component/ddl This issue is related to DDL of TiDB. severity/major type/bug The issue is confirmed as a bug.

Comments

@zimulala
Copy link
Contributor

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

Start a cluster, it has two TiDBs, and the version is v7.1.1.
Then upgrade TiDB1 and TiDB2 to master in the meantime.

  • Before TiDB1 does PauseAllJobsBySystem, TiDB2 does bootstrap's DDL ops(like add column for tidb_background_subtask).
  • Before TiDB2 finishes bootstrap's DDL( add column for tidb_background_subtask), TiDB1 does PauseAllJobsBySystem

2. What did you expect to see? (Required)

Upgrade successfully.

3. What did you see instead (Required)

Upgrade block( add column for tidb_background_subtask block).

4. What is your TiDB version? (Required)

master
@zimulala zimulala added type/bug The issue is confirmed as a bug. component/ddl This issue is related to DDL of TiDB. labels Aug 18, 2023
@zimulala zimulala self-assigned this Aug 18, 2023
@zimulala zimulala mentioned this issue Aug 18, 2023
Closed
@zimulala zimulala mentioned this issue Aug 18, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this issue Aug 21, 2023
@zimulala
session: remove pause all jobs when upgrading (#46234)
8c1d2c8 
close #46227, close #46228
@ti-chi-bot ti-chi-bot mentioned this issue Aug 21, 2023
Merged
12 tasks
@ti-chi-bot ti-chi-bot bot added may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 labels Sep 12, 2023
@zimulala zimulala removed severity/moderate may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 labels Sep 12, 2023
ti-chi-bot bot pushed a commit that referenced this issue Sep 12, 2023
@ti-chi-bot
session: remove pause all jobs when upgrading (#46234) (#46265)
4007579 
close #46227, close #46228
@Benjamin2037 Benjamin2037 mentioned this issue Oct 18, 2023
Merged
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zimulala zimulala

Labels
affects-7.1 component/ddl This issue is related to DDL of TiDB. severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

session: remove pause all jobs when upgrading zimulala/tidb
1 participant
@zimulala