Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session: remove pause all jobs when upgrading #46234

Merged
merged 2 commits into from
Aug 21, 2023

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented Aug 18, 2023

What problem does this PR solve?

Issue Number: close #46228, close #46227

Problem Summary:

What is changed and how it works?

  • remove pause all jobs when upgrading
  • update TestUpgradeWithPauseDDL and add a comment.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    Pass the issue's test.
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@zimulala zimulala requested a review from a team as a code owner August 18, 2023 08:16
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 18, 2023
@tiprow
Copy link

tiprow bot commented Aug 18, 2023

Hi @zimulala. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #46234 (063d9e5) into master (6188778) will decrease coverage by 0.5824%.
Report is 14 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #46234        +/-   ##
================================================
- Coverage   73.3768%   72.7944%   -0.5825%     
================================================
  Files          1285       1306        +21     
  Lines        394364     401209      +6845     
================================================
+ Hits         289372     292058      +2686     
- Misses        86557      90671      +4114     
- Partials      18435      18480        +45     
Flag Coverage Δ
integration 25.6352% <ø> (?)
unit 73.4725% <ø> (+0.0956%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.0667% <ø> (-0.0098%) ⬇️
br 47.9168% <ø> (-4.3758%) ⬇️

@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-triage-completed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 18, 2023
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 18, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 18, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 18, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-18 10:51:18.105452076 +0000 UTC m=+887442.654468063: ☑️ agreed by Defined2014.
  • 2023-08-18 12:27:31.956975136 +0000 UTC m=+893216.505991123: ☑️ agreed by hawkingrei.

@hawkingrei hawkingrei removed the request for review from a team August 18, 2023 12:27
@zimulala
Copy link
Contributor Author

/retest-required

@tiprow
Copy link

tiprow bot commented Aug 21, 2023

@zimulala: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@easonn7
Copy link

easonn7 commented Aug 21, 2023

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, easonn7, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 21, 2023
@zimulala
Copy link
Contributor Author

/retest-required

@tiprow
Copy link

tiprow bot commented Aug 21, 2023

@zimulala: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit 8c1d2c8 into pingcap:master Aug 21, 2023
6 of 9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #46265.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Aug 21, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@zimulala zimulala deleted the zimuxia/fix-concurrent-upgrade branch August 21, 2023 05:46
ti-chi-bot bot pushed a commit that referenced this pull request Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
5 participants