Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log_backup: add some hint about the slow region #51046

Closed
YuJuncen opened this issue Feb 7, 2024 · 4 comments · Fixed by #51137
Closed

log_backup: add some hint about the slow region #51046

YuJuncen opened this issue Feb 7, 2024 · 4 comments · Fixed by #51137
Labels
affects-6.5 affects-7.1 affects-7.5 component/br This issue is related to BR of TiDB. type/enhancement The issue or PR belongs to an enhancement.

Comments

@YuJuncen
Copy link
Contributor

YuJuncen commented Feb 7, 2024

Enhancement

For now, the slow region hint of log backup only provides the range info. It is pretty hard to find the region contains that range in a huge cluster (We need run pd-ctl or something, also note that PD ctl doesn't support querying history data.)
It will be hard to debug checkpoint stuck issues: usually we need to fetch all TiKV's logs and query the start key of some region in ALL logs(!). It is painful.

We can fetch the region metadata once there are some slow regions. That will be pretty lightweight.
@YuJuncen YuJuncen added the type/enhancement The issue or PR belongs to an enhancement. label Feb 7, 2024
@YuJuncen YuJuncen mentioned this issue Feb 19, 2024
Merged
5 tasks
@BornChanger
Copy link
Contributor

/component br

@ti-chi-bot ti-chi-bot bot added the component/br This issue is related to BR of TiDB. label Feb 20, 2024
@BornChanger
Copy link
Contributor

/label affects-6.5

@BornChanger
Copy link
Contributor

/label affects-7.1

@BornChanger
Copy link
Contributor

/label affects-7.5

ti-chi-bot bot pushed a commit that referenced this issue Feb 20, 2024
@YuJuncen
log_backup: added more info for slow regions in log backup advancer (#…
58e3735 
…51137)

close #51046
This was referenced Feb 20, 2024
Merged
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this issue Feb 20, 2024
@ti-chi-bot
log_backup: added more info for slow regions in log backup advancer (#…
15064f4 
…51137) (#51174)

close #51046
ti-chi-bot bot pushed a commit that referenced this issue Feb 27, 2024
@ti-chi-bot
log_backup: added more info for slow regions in log backup advancer (#…
0c5736b 
…51137) (#51175)

close #51046
ti-chi-bot bot pushed a commit that referenced this issue Mar 25, 2024
@ti-chi-bot
log_backup: added more info for slow regions in log backup advancer (#…
b44ddb7 
…51137) (#51173)

close #51046
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.5 affects-7.1 affects-7.5 component/br This issue is related to BR of TiDB. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

log_backup: added more info for slow regions in log backup advancer YuJuncen/tidb
2 participants
@YuJuncen @BornChanger