-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
txn: use ART as membuffer #55287
Labels
report/customer
Customers have encountered this bug.
type/feature-request
Categorizes issue or PR as related to a new feature.
Comments
you06
added
the
type/feature-request
Categorizes issue or PR as related to a new feature.
label
Aug 8, 2024
This was referenced Aug 8, 2024
ti-chi-bot bot
pushed a commit
to tikv/client-go
that referenced
this issue
Aug 23, 2024
ref pingcap/tidb#55287 Signed-off-by: you06 <you1474600@gmail.com>
ti-chi-bot bot
pushed a commit
to tikv/client-go
that referenced
this issue
Sep 18, 2024
ref pingcap/tidb#55287 Signed-off-by: you06 <you1474600@gmail.com>
ti-chi-bot bot
pushed a commit
to tikv/client-go
that referenced
this issue
Sep 23, 2024
ref pingcap/tidb#55287 Signed-off-by: you06 <you1474600@gmail.com>
ti-chi-bot bot
pushed a commit
to tikv/client-go
that referenced
this issue
Sep 24, 2024
ref pingcap/tidb#55287 Signed-off-by: you06 <you1474600@gmail.com>
ti-chi-bot bot
pushed a commit
to tikv/client-go
that referenced
this issue
Sep 25, 2024
ref pingcap/tidb#55287 Signed-off-by: you06 <you1474600@gmail.com>
13 tasks
ti-chi-bot bot
pushed a commit
to tikv/client-go
that referenced
this issue
Oct 8, 2024
ref pingcap/tidb#55287 Signed-off-by: you06 <you1474600@gmail.com>
13 tasks
This was referenced Oct 28, 2024
ti-chi-bot
bot
added
affects-6.5
This bug affects the 6.5.x(LTS) versions.
report/customer
Customers have encountered this bug.
labels
Oct 28, 2024
ti-chi-bot bot
pushed a commit
to tikv/client-go
that referenced
this issue
Oct 31, 2024
ref pingcap/tidb#55287 Signed-off-by: you06 <you1474600@gmail.com>
ti-chi-bot bot
pushed a commit
to tikv/client-go
that referenced
this issue
Nov 7, 2024
ref pingcap/tidb#55287 Signed-off-by: you06 <you1474600@gmail.com>
13 tasks
13 tasks
This was referenced Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
report/customer
Customers have encountered this bug.
type/feature-request
Categorizes issue or PR as related to a new feature.
Feature Request
Is your feature request related to a problem? Please describe:
The membuffer stores written mutations before commit statement, it serves in-txn read also(in union scan), which is a core module of TiDB.
The current implementation is a red-black tree, which is fine, but the performance is such higher in TiDB's use case. Because the keys in TiDB usually have a long common prefix, thus performs not such good in index based on key comparation.
Describe the feature you'd like:
The ART is a radix tree in-mem index, which is friendly to long common prefix keys, in our test, it outperforms the current implementation in almost all cases.
Describe alternatives you've considered:
N/A
Teachability, Documentation, Adoption, Migration Strategy:
To be finished.
Development Tracking
The text was updated successfully, but these errors were encountered: