Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

membuffer: refactor the memdb to support multi implementations #1426

Merged
merged 9 commits into from
Aug 23, 2024
Merged

membuffer: refactor the memdb to support multi implementations #1426

merged 9 commits into from
Aug 23, 2024

Conversation

you06
Copy link
Contributor

@you06 you06 commented Aug 20, 2024 •
edited
Loading

ref pingcap/tidb#55287

This PR mainly contains 3 changes:

  • Split the memory arena and vlog from the red-black tree memory arena implementation.
  • Add the empty framework of ART.
  • Make ART, RBT and memory arena different packages.

you06 added 3 commits August 19, 2024 17:12
@you06
refactor memdb to support multi implementations
2f2a789 
Signed-off-by: you06 <you1474600@gmail.com>
@you06
leave ART's framework only
1cab0b1 
Signed-off-by: you06 <you1474600@gmail.com>
@you06
refine comment
f9239c4 
Signed-off-by: you06 <you1474600@gmail.com>
@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 20, 2024
cfzjywxk
cfzjywxk reviewed Aug 21, 2024
View reviewed changes
internal/unionstore/art.go Outdated Show resolved Hide resolved
internal/unionstore/art.go Outdated Show resolved Hide resolved
internal/unionstore/art_node.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 21, 2024
you06 added 5 commits August 22, 2024 15:35
@you06
Merge branch 'master' into refactor-memdb
deb699d
@you06
make rbt, art and memory arena 3 packages
fa9b0e2 
Signed-off-by: you06 <you1474600@gmail.com>
@you06
remove comments
8bb8cb4 
Signed-off-by: you06 <you1474600@gmail.com>
@you06
fix GetMemDB
4cc4bc6 
Signed-off-by: you06 <you1474600@gmail.com>
@you06
extract RWMutex out of RBT & ART
84ece36 
Signed-off-by: you06 <you1474600@gmail.com>
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, zyguan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 23, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 23, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-21 03:42:38.132826775 +0000 UTC m=+323353.267276894: ☑️ agreed by zyguan.
  • 2024-08-23 03:45:47.355988688 +0000 UTC m=+496342.490438809: ☑️ agreed by cfzjywxk.

@ti-chi-bot ti-chi-bot bot merged commit 41d133b into tikv:master Aug 23, 2024
3 checks passed
@you06 you06 mentioned this pull request Sep 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zyguan zyguan zyguan approved these changes

@cfzjywxk cfzjywxk cfzjywxk approved these changes

@MyonKeminta MyonKeminta Awaiting requested review from MyonKeminta

@crazycs520 crazycs520 Awaiting requested review from crazycs520

@ekexium ekexium Awaiting requested review from ekexium

Assignees
No one assigned
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@you06 @cfzjywxk @zyguan