Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource_control: Add resource limit for background task #56019

Closed
glorv opened this issue Sep 11, 2024 · 0 comments · Fixed by #56020
Closed

resource_control: Add resource limit for background task #56019

glorv opened this issue Sep 11, 2024 · 0 comments · Fixed by #56020
Labels
type/feature-request Categorizes issue or PR as related to a new feature.

Comments

@glorv
Copy link
Contributor

glorv commented Sep 11, 2024

Feature Request

Is your feature request related to a problem? Please describe:

Current, the background task control of resource_control is based on the total resource quota(CPU, IO) of each tikv instance. But in real use cases, foreground tail lantency increase significantly before resource is fully used. So we need to set some kind of limit that background tasks can use so user can control the performance impact by background tasks.

Current background settings:

ALTERR RESOURCE GROUP default BACKGROUND=(TASK_TYPES="br,import");

New SQL pattern:

ALTERR RESOURCE GROUP default BACKGROUND=(TASK_TYPES="br,import", UTILIZATION_LIMIT=30);

We add a new field UTILIZATION_LIMIT (for the default resource group) to control the resource percentage that background tasks can use.

Describe the feature you'd like:

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature-request Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant