Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource_control: add new grafana panel for background task utilization #56285

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

glorv
Copy link
Contributor

@glorv glorv commented Sep 25, 2024

What problem does this PR solve?

Issue Number: ref #56019

Problem Summary:

What changed and how does it work?

New panel:

image

Alter adjust the order of background tasks panels:
image
image

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@glorv glorv requested review from JmPotato and nolouch September 25, 2024 06:31
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 25, 2024
Copy link

tiprow bot commented Sep 25, 2024

Hi @glorv. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 25, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 25, 2024
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.5853%. Comparing base (fd38012) to head (e77d9d5).
Report is 33 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #56285        +/-   ##
================================================
+ Coverage   73.4525%   76.5853%   +3.1327%     
================================================
  Files          1605       1607         +2     
  Lines        444823     455805     +10982     
================================================
+ Hits         326734     349080     +22346     
+ Misses        98037      86528     -11509     
- Partials      20052      20197       +145     
Flag Coverage Δ
integration 50.7529% <ø> (?)
unit 73.8713% <ø> (+1.3278%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 52.9596% <ø> (+6.9420%) ⬆️

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 25, 2024
Copy link

ti-chi-bot bot commented Sep 25, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-25 06:34:34.848369909 +0000 UTC m=+1634144.588793846: ☑️ agreed by JmPotato.
  • 2024-09-25 09:09:29.132012546 +0000 UTC m=+1643438.872436484: ☑️ agreed by nolouch.

@glorv
Copy link
Contributor Author

glorv commented Sep 26, 2024

/approve

Copy link

ti-chi-bot bot commented Sep 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: glorv, JmPotato, nolouch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 26, 2024
@glorv
Copy link
Contributor Author

glorv commented Sep 26, 2024

/test check-dev2

Copy link

tiprow bot commented Sep 26, 2024

@glorv: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit 1b4b2f0 into pingcap:master Sep 26, 2024
23 checks passed
@glorv glorv deleted the utilization-panel branch September 26, 2024 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants