Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more db pool size is needed for br to create many databases #56866

Closed
Leavrth opened this issue Oct 28, 2024 · 1 comment · Fixed by #56867
Closed

more db pool size is needed for br to create many databases #56866

Leavrth opened this issue Oct 28, 2024 · 1 comment · Fixed by #56867
Labels
component/br This issue is related to BR of TiDB. type/enhancement The issue or PR belongs to an enhancement.

Comments

@Leavrth
Copy link
Contributor

Leavrth commented Oct 28, 2024

Enhancement

Currently, BR only has 16 db pools to create databases, and it takes about more than one hour to create 200K databases. However, if BR uses 100 db pools to create databases, it only takes about half an hour to finish create 200K databases.

tidb/br/pkg/restore/snap_client/client.go

Line 69 in c550aae

defaultDDLConcurrency = 16

@Leavrth Leavrth added type/enhancement The issue or PR belongs to an enhancement. component/br This issue is related to BR of TiDB. labels Oct 28, 2024
@Leavrth Leavrth mentioned this issue Oct 28, 2024
Merged
13 tasks
@princejha95
Copy link

Why we are only thinking till 200K databases ? Would this number can change in future ? If yes, we again have to make similar changes, right ?

ti-chi-bot bot pushed a commit that referenced this issue Oct 30, 2024
@Leavrth
br: more db pools to create databases (#56867)
c75d36d 
close #56866
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/br This issue is related to BR of TiDB. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

br: more db pools to create databases Leavrth/tidb
2 participants
@princejha95 @Leavrth