-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br: more db pools to create databases #56867
br: more db pools to create databases #56867
Conversation
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
Hi @Leavrth. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #56867 +/- ##
=================================================
- Coverage 73.3393% 57.5897% -15.7496%
=================================================
Files 1636 1778 +142
Lines 453658 640011 +186353
=================================================
+ Hits 332710 368581 +35871
- Misses 100561 246926 +146365
- Partials 20387 24504 +4117
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Why we are only thinking till 200K databases ? Would this number can change in future ? If yes, we again have to make similar changes, right ? |
hi, @princejha95 .
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3pointer, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
What problem does this PR solve?
Issue Number: close #56866
Problem Summary:
Currently, BR only has 16 db pools to create databases, and it takes about more than one hour to create 200K databases.
What changed and how does it work?
Use 100 db pools to create databases, and it only takes about half an hour to finish create 200K databases.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.