Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TTL Task cannot be canceled if the TiDB lost heartbeat #57784

Closed
YangKeao opened this issue Nov 28, 2024 · 0 comments · Fixed by #57788
Closed

TTL Task cannot be canceled if the TiDB lost heartbeat #57784

YangKeao opened this issue Nov 28, 2024 · 0 comments · Fixed by #57788
Assignees
Labels
affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. affects-8.5 This bug affects the 8.5.x(LTS) versions. severity/moderate sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.

Comments

@YangKeao
Copy link
Member

Bug Report

// checkInvalidTask removes the task whose owner is not myself or which has disappeared
func (m *taskManager) checkInvalidTask(se session.Session) {
...

		if t.OwnerID == m.id {
			ownRunningTask = append(ownRunningTask, task)
		}
	}

	m.runningTasks = ownRunningTask
}

If the t.OwnerID != m.id, the task should also be canceled and release the worker.

@YangKeao YangKeao added the type/bug The issue is confirmed as a bug. label Nov 28, 2024
@ti-chi-bot ti-chi-bot bot closed this as completed in 018ab99 Dec 2, 2024
@YangKeao YangKeao added affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. affects-8.5 This bug affects the 8.5.x(LTS) versions. labels Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. affects-8.5 This bug affects the 8.5.x(LTS) versions. severity/moderate sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant