Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unexport the important fields of statistics.Column and statistics.Index #57949

Open
winoros opened this issue Dec 3, 2024 · 0 comments
Open

unexport the important fields of statistics.Column and statistics.Index #57949

winoros opened this issue Dec 3, 2024 · 0 comments
Assignees
@winoros
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@winoros
Copy link
Member

winoros commented Dec 3, 2024

Enhancement

To make the MemoryUsage be O(1) safely. We need to make sure that the fields of Column and Index is not changed by accident.
Hence, we are going to unexport the important fields of them.
@winoros winoros added the type/enhancement The issue or PR belongs to an enhancement. label Dec 3, 2024
@winoros winoros self-assigned this Dec 3, 2024
@winoros winoros mentioned this issue Dec 3, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Dec 4, 2024
@winoros
statistics: move JSON* to statistics/util (#57950)
da965d1 
ref #57949
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@winoros winoros

Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@winoros