-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
statistics: move JSON* to statistics/util #57950
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #57950 +/- ##
================================================
+ Coverage 73.1804% 75.1476% +1.9671%
================================================
Files 1671 1719 +48
Lines 460724 471243 +10519
================================================
+ Hits 337160 354128 +16968
+ Misses 102835 95048 -7787
- Partials 20729 22067 +1338
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, Leavrth, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test build |
@purelind: The specified target(s) for
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retest |
What problem does this PR solve?
Issue Number: ref #57949
Problem Summary:
To solve the cyclic import problem during refactoring
statistics.Column
andstatistics.Index
, we need to move the objects into a new place.What changed and how does it work?
To make
MemoryUsage
safe to beo(1)
. We need to make sure the Column/Index not changed by accident.This pr is one step of make the important fields of them private.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.