Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: move JSON* to statistics/util #57950

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

winoros
Copy link
Member

@winoros winoros commented Dec 3, 2024

What problem does this PR solve?

Issue Number: ref #57949

Problem Summary:

To solve the cyclic import problem during refactoring statistics.Column and statistics.Index, we need to move the objects into a new place.

What changed and how does it work?

To make MemoryUsage safe to be o(1). We need to make sure the Column/Index not changed by accident.

This pr is one step of make the important fields of them private.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 3, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 3, 2024
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 98.30508% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.1476%. Comparing base (edba7e9) to head (43438c7).
Report is 11 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #57950        +/-   ##
================================================
+ Coverage   73.1804%   75.1476%   +1.9671%     
================================================
  Files          1671       1719        +48     
  Lines        460724     471243     +10519     
================================================
+ Hits         337160     354128     +16968     
+ Misses       102835      95048      -7787     
- Partials      20729      22067      +1338     
Flag Coverage Δ
integration 49.2605% <18.6440%> (?)
unit 72.5822% <98.3050%> (+0.2625%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 61.6349% <ø> (+15.6486%) ⬆️

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 4, 2024
Copy link

ti-chi-bot bot commented Dec 4, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-03 15:33:04.045470032 +0000 UTC m=+1168971.665124542: ☑️ agreed by tangenta.
  • 2024-12-04 01:32:16.383623439 +0000 UTC m=+1204924.003277955: ☑️ agreed by Leavrth.

Copy link

ti-chi-bot bot commented Dec 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, Leavrth, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 4, 2024
@purelind
Copy link
Contributor

purelind commented Dec 4, 2024

/test build

Copy link

tiprow bot commented Dec 4, 2024

@purelind: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test fast_test_tiprow_ddlargsv1
  • /test tidb_parser_test

Use /test all to run the following jobs that were automatically triggered:

  • fast_test_tiprow
  • tidb_parser_test

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@winoros
Copy link
Member Author

winoros commented Dec 4, 2024

/retest

@ti-chi-bot ti-chi-bot bot merged commit da965d1 into pingcap:master Dec 4, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants