Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TTL getSession function may return unexpected result #58107

Closed
YangKeao opened this issue Dec 9, 2024 · 1 comment · Fixed by #58166
Closed

TTL getSession function may return unexpected result #58107

YangKeao opened this issue Dec 9, 2024 · 1 comment · Fixed by #58166
Labels
severity/minor sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.

Comments

@YangKeao
Copy link
Member

YangKeao commented Dec 9, 2024

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

The function getSession returns a session and an error. It's expected to return either session or an error. However, it's possible that both of them are nil, because the Close() function may overwrite the err return value.

2. What did you expect to see? (Required)

At least one of session and err are not nil.

3. What did you see instead (Required)

Both of them are nil if the session is error.

@YangKeao YangKeao added type/bug The issue is confirmed as a bug. sig/sql-infra SIG: SQL Infra severity/minor labels Dec 9, 2024
@YangKeao
Copy link
Member Author

YangKeao commented Dec 9, 2024

I believe it's a super corner case and will rarely occur in real world.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity/minor sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant