If a TTL job is cancelled, the last_job_finish_time is incorrect.

[YangKeao]

The first assert intest.Assert(se.GetSessionVars().Location().String() == now.Location().String()) in job.finish is never true when job.finish is called from rescheduleJobs (but our tests didn't cover it yet). It's because in rescheduleJobs the now is in GlobalTimeZone (Asia/Shanghai in my case), and the se.GetSessionVars().Location().String() is always UTC.

It'll not be a big issue as the job is scheduled according to the start time, but the wrong finish time is still confusing for users.

[YangKeao]

I'll construct a case to reproduce it with real scenario (but not reading codes only).

[YangKeao]

I reproduced it:

mysql> select * from mysql.tidb_ttl_table_status;
+----------+-----------------+------------------+----------------------------------+---------------------+----------------------+---------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+----------------+----------------------+------------------------+---------------------------+------------------------+------------------------+-------------------+--------------------+--------------------------------+
| table_id | parent_table_id | table_statistics | last_job_id                      | last_job_start_time | last_job_finish_time | last_job_ttl_expire | last_job_summary                                                                                                                                                                                           | current_job_id | current_job_owner_id | current_job_owner_addr | current_job_owner_hb_time | current_job_start_time | current_job_ttl_expire | current_job_state | current_job_status | current_job_status_update_time |
+----------+-----------------+------------------+----------------------------------+---------------------+----------------------+---------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+----------------+----------------------+------------------------+---------------------------+------------------------+------------------------+-------------------+--------------------+--------------------------------+
|      118 |             118 | NULL             | 962a363d8240424b9f17f32ea021a039 | 2024-12-10 02:02:15 | 2024-12-10 10:04:07  | 2024-12-10 01:02:15 | {"total_rows":0,"success_rows":0,"error_rows":0,"total_scan_task":0,"scheduled_scan_task":0,"finished_scan_task":0,"scan_task_err":"TTL table has been removed or the TTL on this table has been stopped"} | NULL           | NULL                 | NULL                   | NULL                      | NULL                   | NULL                   | NULL              | NULL               | NULL                           |
+----------+-----------------+------------------+----------------------------------+---------------------+----------------------+---------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+----------------+----------------------+------------------------+---------------------------+------------------------+------------------------+-------------------+--------------------+--------------------------------+
1 row in set (0.00 sec)

The correct last_job_finish_time should be very near to last_job_start_time, but it shifted more 8 hours.