*: Add support "show open tables" #10166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TiDB has no concept like mysql's "table cache" and "open table" For simplicity, we just return an empty result with the same structure as MySQL's SHOW OPEN TABLES
|
LGTM |
|
LGTM |
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #10166 +/- ##
===============================================
+ Coverage 77.927% 77.9436% +0.0165%
===============================================
Files 407 407
Lines 82898 82951 +53
===============================================
+ Hits 64600 64655 +55
+ Misses 13509 13505 -4
- Partials 4789 4791 +2 |
|
/run-all-tests |
|
/run-unit-test |
july2993
added
status/LGT2
|
LGTM |
|
can anyone help approve and merge it? |
morgo
approved these changes
Apr 19, 2019
|
@july2993 I have approved it. |
zimulala
pushed a commit
to zimulala/tidb
that referenced
this pull request
May 7, 2019
TiDB has no concept like mysql's "table cache" and "open table" For simplicity, we just return an empty result with the same structure as MySQL's SHOW OPEN TABLES
zimulala
added a commit
that referenced
this pull request
May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix #10070
relate parser pr: pingcap/parser#291
What is changed and how it works?
TiDB has no concept like mysql's "table cache" and "open table"
For simplicity, we just return an empty result with the same structure
as MySQL's SHOW OPEN TABLES
Check List
Tests
build and run "show open tables" using mysql client
Code changes
Side effects
Related changes