Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Add support "show open tables" (#10166) #10374

Merged
merged 4 commits into from
May 29, 2019

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented May 7, 2019

Cherry-pick #10166 to v2.1

Related to pingcap/parser#317

TiDB has no concept like mysql's "table cache" and "open table"
For simplicity, we just return an empty result with the same structure
as MySQL's SHOW OPEN TABLES
@zimulala
Copy link
Contributor Author

zimulala commented May 7, 2019

/run-all-test tidb-test=release-2.1 tidb-private-test=release-2.1 tikv=release-2.1

@zimulala
Copy link
Contributor Author

zimulala commented May 7, 2019

/run-all-test tidb-test=release-2.1 tidb-private-test=release-2.1 tikv=release-2.1

@zimulala
Copy link
Contributor Author

zimulala commented May 7, 2019

PTAL @tiancaiamao @winkyao

@tiancaiamao
Copy link
Contributor

LGTM

@tiancaiamao tiancaiamao added the status/LGT1 Indicates that a PR has LGTM 1. label May 8, 2019
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp
Copy link
Member

jackysp commented May 10, 2019

/run-all-tests tidb-test=release-2.1 tidb-private-test=release-2.1 tikv=release-2.1

jackysp
jackysp previously approved these changes May 10, 2019
@tiancaiamao
Copy link
Contributor

Please fix CI @zimulala

@zimulala zimulala added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 29, 2019
@zimulala zimulala merged commit 201a89b into pingcap:release-2.1 May 29, 2019
@zimulala zimulala deleted the show-open branch May 29, 2019 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT2 Indicates that a PR has LGTM 2. type/compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants