-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor,sessionctx: refine output format for tidb-specific variables of boolean type #11239
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11239 +/- ##
===========================================
Coverage ? 81.5579%
===========================================
Files ? 423
Lines ? 90993
Branches ? 0
===========================================
Hits ? 74212
Misses ? 11493
Partials ? 5288 |
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @spongedu ! |
It seems that, not for sure, we failed to cherry-pick this commit to release-2.1 release-3.0. Please comment '/run-cherry-picker' to try to trigger the cherry-picker if we did fail to cherry-pick this commit before. @wshwsh12 PTAL. |
/run-cherry-picker |
cherry pick to release-2.1 in PR #16131 |
cherry pick to release-3.0 in PR #16132 |
cherry pick to release-3.1 in PR #16133 |
What problem does this PR solve?
Currently, the result of selecting tidb-specific variables of boolean type is not well formatted. I think we'd better make it same style with MySQL. For example:
What is changed and how it works?
Check List
Tests
Code changes
N / A
Side effects
N / A
Related changes
N / A