-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor,sessionctx: refine output format for tidb-specific variables of boolean type (#11239) #16131
Merged
sre-bot
merged 2 commits into
pingcap:release-2.1
from
sre-bot:release-2.1-d381d84d1bf9
Apr 14, 2020
Merged
executor,sessionctx: refine output format for tidb-specific variables of boolean type (#11239) #16131
sre-bot
merged 2 commits into
pingcap:release-2.1
from
sre-bot:release-2.1-d381d84d1bf9
Apr 14, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/run-all-tests |
sre-bot
added
contribution
This PR is from a community contributor.
status/all-tests-passed
type/2.1-cherry-pick
type/compatibility
labels
Apr 7, 2020
@wshwsh12 Please resolve the conlicts |
wshwsh12
force-pushed
the
release-2.1-d381d84d1bf9
branch
from
April 12, 2020 15:42
0d327e2
to
420e9f1
Compare
zz-jason
reviewed
Apr 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
XuHuaiyu
approved these changes
Apr 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
zz-jason
added
status/LGT2
Indicates that a PR has LGTM 2.
and removed
status/LGT1
Indicates that a PR has LGTM 1.
labels
Apr 14, 2020
zz-jason
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
Apr 14, 2020
Your auto merge job has been accepted, waiting for 16307 |
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
contribution
This PR is from a community contributor.
sig/execution
SIG execution
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT2
Indicates that a PR has LGTM 2.
type/compatibility
type/2.1-cherry-pick
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #11239 to release-2.1
What problem does this PR solve?
Currently, the result of selecting tidb-specific variables of boolean type is not well formatted. I think we'd better make it same style with MySQL. For example:
What is changed and how it works?
Check List
Tests
Code changes
N / A
Side effects
N / A
Related changes
N / A