-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: make regex binary
and rlike binary
be case sensitive
#11502
Conversation
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #11502 +/- ##
================================================
- Coverage 81.3774% 81.3532% -0.0242%
================================================
Files 424 424
Lines 90922 90922
================================================
- Hits 73990 73968 -22
- Misses 11619 11632 +13
- Partials 5313 5322 +9 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #11502 +/- ##
================================================
- Coverage 81.3774% 81.3532% -0.0242%
================================================
Files 424 424
Lines 90922 90922
================================================
- Hits 73990 73968 -22
- Misses 11619 11632 +13
- Partials 5313 5322 +9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cherry pick to release-3.0 in PR #11504 |
cherry pick to release-2.1 in PR #11505 |
What problem does this PR solve?
In current TiDB,
regexp binary
is case insensitive.but MySQL is case sensitive:
What is changed and how it works?
not only check the first argument('a') but also the second argument(binary 'A') to decide whether using
builtinRegexpBinarySig
Check List
Tests
Code changes
Side effects
Related changes
This change is