Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: make regex binary and rlike binary be case sensitive (#11502) #11505

Merged
merged 3 commits into from
Jul 30, 2019
Merged

expression: make regex binary and rlike binary be case sensitive (#11502) #11505

merged 3 commits into from
Jul 30, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Jul 29, 2019

cherry-pick #11502 to release-2.1

@sre-bot
Copy link
Contributor Author

sre-bot commented Jul 29, 2019

/run-all-tests

@sre-bot sre-bot mentioned this pull request Jul 29, 2019
Merged
@zz-jason zz-jason requested a review from SunRunAway July 30, 2019 01:33
zz-jason
zz-jason reviewed Jul 30, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 30, 2019
SunRunAway
SunRunAway approved these changes Jul 30, 2019
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway SunRunAway added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 30, 2019
@sre-bot
Copy link
Contributor Author

sre-bot commented Jul 30, 2019

/run-all-tests

@sre-bot sre-bot merged commit cb05ebb into pingcap:release-2.1 Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@SunRunAway SunRunAway SunRunAway approved these changes

Assignees
No one assigned
Labels
component/expression status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sre-bot @SunRunAway @zz-jason @lysu @ngaut