planner: function name in ErrWindowInvalidWindowFuncUse should be lowercase
#11520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi contributor, thanks for your PR. This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically. |
|
@SunRunAway PTAL |
alivxxx
added
the
status/can-merge
|
/run-all-tests |
winoros
changed the title
ErrWindowInvalidWindowFuncUse should be lowercase
|
@tcmichael merge failed. |
|
/run-common-test tidb-test=pr/868 |
|
/run-common-test tidb-test=pr/868 |
1 similar comment
|
/run-common-test tidb-test=pr/868 |
Codecov Report
@@ Coverage Diff @@
## master #11520 +/- ##
===========================================
Coverage 81.3577% 81.3577%
===========================================
Files 425 425
Lines 91389 91389
===========================================
Hits 74352 74352
Misses 11705 11705
Partials 5332 5332 |
|
/run-all-tests tidb-test=pr/868 |
|
cherry pick to release-3.0 in PR #11535 |
|
cherry pick to release-2.1 failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
window function: function name of ErrWindowInvalidWindowFuncUse should be lowercase.
Closes #11508
What is changed and how it works?
warp Function name with strings.ToLower()
Check List
Tests