Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: function name in ErrWindowInvalidWindowFuncUse should be lowercase (#11520) #11535

Merged
merged 2 commits into from
Aug 1, 2019
Merged

planner: function name in ErrWindowInvalidWindowFuncUse should be lowercase (#11520) #11535

merged 2 commits into from
Aug 1, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Jul 31, 2019

cherry-pick #11520 to release-3.0

@sre-bot
Copy link
Contributor Author

sre-bot commented Jul 31, 2019

/run-all-tests

@sre-bot sre-bot mentioned this pull request Jul 31, 2019
Merged
@sre-bot sre-bot added component/expression contribution This PR is from a community contributor. type/3.0 cherry-pick type/bugfix This PR fixes a bug. labels Jul 31, 2019
zz-jason
zz-jason reviewed Jul 31, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason requested review from SunRunAway and alivxxx July 31, 2019 03:36
SunRunAway
SunRunAway approved these changes Jul 31, 2019
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway SunRunAway added the status/can-merge Indicates a PR has been approved by a committer. label Jul 31, 2019
@sre-bot
Copy link
Contributor Author

sre-bot commented Jul 31, 2019

/run-all-tests

@jackysp jackysp mentioned this pull request Jul 31, 2019
Merged
@sre-bot
Copy link
Contributor Author

sre-bot commented Jul 31, 2019

@sre-bot merge failed.

@imtbkcat
Copy link

/run-all-tests

@lzmhhh123 lzmhhh123 added status/can-merge Indicates a PR has been approved by a committer. and removed status/can-merge Indicates a PR has been approved by a committer. labels Jul 31, 2019
@sre-bot
Copy link
Contributor Author

sre-bot commented Jul 31, 2019

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Jul 31, 2019

@sre-bot merge failed.

@lzmhhh123
Copy link
Contributor

/rebuild

@zz-jason
Copy link
Member

zz-jason commented Aug 1, 2019

/run-unit-test

@zz-jason zz-jason merged commit 46246b3 into pingcap:release-3.0 Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@SunRunAway SunRunAway SunRunAway approved these changes

@alivxxx alivxxx Awaiting requested review from alivxxx

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sre-bot @imtbkcat @lzmhhh123 @zz-jason @SunRunAway