expression: deduce result type for multi-argument functions like IF wrongly in some cases
#11605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qw4990
added
type/bugfix
XuHuaiyu
reviewed
Aug 5, 2019
Codecov Report
@@ Coverage Diff @@
## master #11605 +/- ##
===========================================
Coverage 81.2608% 81.2608%
===========================================
Files 426 426
Lines 92176 92176
===========================================
Hits 74903 74903
Misses 11897 11897
Partials 5376 5376 |
zz-jason
reviewed
Aug 5, 2019
|
/run-all-tests |
zz-jason
added
status/can-merge
|
/run-all-tests |
|
cherry pick to release-2.1 failed |
|
cherry pick to release-3.0 in PR #11621 |
qw4990
added a commit
to qw4990/tidb
that referenced
this pull request
Aug 8, 2019
… wrongly in some cases (pingcap#11605)
|
It seems that, not for sure, we failed to cherry-pick this commit to release-2.1. Please comment '/run-cherry-picker' to try to trigger the cherry-picker if we did fail to cherry-pick this commit before. @qw4990 PTAL. |
qw4990
added a commit
to qw4990/tidb
that referenced
this pull request
Apr 13, 2020
… wrongly in some cases (pingcap#11605)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix #11594;
When we deduce the result type for a multi-argument function like
IF, we don't takesigned/unsignedflag into account now;What is changed and how it works?
If anyone of these input arguments is not unsigned, we set the result type to signed.
Check List
Tests