Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: deduce result type for multi-argument functions like IF wrongly in some cases (#11605) #16310

Merged
merged 3 commits into from
Apr 14, 2020
Merged

expression: deduce result type for multi-argument functions like IF wrongly in some cases (#11605) #16310

merged 3 commits into from
Apr 14, 2020

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Apr 13, 2020

cherry-pick for #11605

@qw4990 qw4990 requested review from zz-jason and XuHuaiyu April 13, 2020 03:12
zz-jason
zz-jason reviewed Apr 13, 2020
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 13, 2020
XuHuaiyu
XuHuaiyu approved these changes Apr 13, 2020
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XuHuaiyu
Copy link
Contributor

/run-all-tests

@qw4990 qw4990 added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 13, 2020
@SunRunAway SunRunAway added the status/can-merge Indicates a PR has been approved by a committer. label Apr 14, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 14, 2020

Your auto merge job has been accepted, waiting for 16117, 16326

@sre-bot
Copy link
Contributor

sre-bot commented Apr 14, 2020

/run-all-tests

@sre-bot sre-bot merged commit cc8b2eb into pingcap:release-2.1 Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

Assignees
No one assigned
Labels
component/expression status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/2.1-cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@qw4990 @XuHuaiyu @sre-bot @zz-jason @SunRunAway