planner: split test data from test cases #12091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #12091 +/- ##
===========================================
Coverage 81.4675% 81.4675%
===========================================
Files 449 449
Lines 96080 96080
===========================================
Hits 78274 78274
Misses 12222 12222
Partials 5584 5584 |
winoros
reviewed
Sep 9, 2019
lzmhhh123
reviewed
Sep 9, 2019
| { | ||
| "name": "TestIndexHint", | ||
| "cases": [ | ||
| // simple case |
There was a problem hiding this comment.
Does the json file support comments?
There was a problem hiding this comment.
No, so before parse, the comment will be removed.
alivxxx
added
status/LGT2
|
Your auto merge job has been accepted, waiting for #12109 |
|
/run-all-tests |
|
@lamxTyler merge failed. |
|
/run-unit-test |
alivxxx
added a commit
to alivxxx/tidb
that referenced
this pull request
Sep 27, 2019
alivxxx
added a commit
to alivxxx/tidb
that referenced
this pull request
Sep 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
When there is a change that affects lots of test cases in planner, it is very diffcult to update the test cases.
What is changed and how it works?
Split test data from test logic so we can generate test cases by one command:
go test --record.This PR uses
TestIndexHintas a sample. We can split more tests once the test framework is settled.Check List
Tests
Code changes
Side effects
Related changes
Release note