Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner/core: split test data from physical plan test #12132

Merged
merged 3 commits into from
Sep 10, 2019
Merged

planner/core: split test data from physical plan test #12132

merged 3 commits into from
Sep 10, 2019

Conversation

alivxxx
Copy link
Contributor

@alivxxx alivxxx commented Sep 10, 2019

What problem does this PR solve?

Split test data from physical_plan_test.go to make it easier to update result.

What is changed and how it works?

Using the new test framework that introduced in #12091

Check List

Tests

  • No code

Code changes

  • None

Side effects

  • None

Related changes

  • None

Release note

  • None

@codecov
Copy link

codecov bot commented Sep 10, 2019 •
edited
Loading

Codecov Report

Merging #12132 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #12132   +/-   ##
===========================================
  Coverage   81.3564%   81.3564%           
===========================================
  Files           450        450           
  Lines         96602      96602           
===========================================
  Hits          78592      78592           
  Misses        12381      12381           
  Partials       5629       5629

eurekaka
eurekaka reviewed Sep 10, 2019
View reviewed changes
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 10, 2019
winoros
winoros approved these changes Sep 10, 2019
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alivxxx alivxxx added status/LGT2 Indicates that a PR has LGTM 2. status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 10, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 10, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Sep 10, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Sep 10, 2019

@lamxTyler merge failed.

@alivxxx alivxxx merged commit 4621bf3 into pingcap:master Sep 10, 2019
@alivxxx alivxxx deleted the split-test branch September 10, 2019 11:51
alivxxx added a commit to alivxxx/tidb that referenced this pull request Sep 27, 2019
@alivxxx
planner/core: split test data from physical plan test (pingcap#12132)
57e1ff0
alivxxx added a commit to alivxxx/tidb that referenced this pull request Sep 27, 2019
@alivxxx
planner/core: split test data from physical plan test (pingcap#12132)
cc0ef99
alivxxx added a commit to alivxxx/tidb that referenced this pull request Sep 27, 2019
@alivxxx
planner/core: split test data from physical plan test (pingcap#12132)
59e3dc0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eurekaka eurekaka eurekaka left review comments

@winoros winoros winoros approved these changes

@lzmhhh123 lzmhhh123 Awaiting requested review from lzmhhh123

Assignees
No one assigned
Labels
component/test status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alivxxx @sre-bot @eurekaka @winoros