Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: display column collate in show create table #12327

Merged
merged 9 commits into from
Sep 27, 2019
Merged

executor: display column collate in show create table #12327

merged 9 commits into from
Sep 27, 2019

Conversation

tsthght
Copy link
Contributor

@tsthght tsthght commented Sep 24, 2019

What problem does this PR solve?

fix bug for #11831。should display collate of the column, but did not。

create table ttt4(a varchar(123) default null collate utf8mb4_unicode_ci)engine=innodb default charset=utf8mb4 collate=utf8mb4_unicode_ci;
show create table ttt4;
mysql> show create table ttt4\G
*************************** 1. row ***************************
Table: ttt4
Create Table: CREATE TABLE ttt4 (
a varchar(123) DEFAULT NULL
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci
1 row in set (0.00 sec)

What is changed and how it works?

mysql> show create table ttt4\G
*************************** 1. row ***************************
Table: ttt4
Create Table: CREATE TABLE ttt4 (
a varchar(123) COLLATE utf8mb4_unicode_ci DEFAULT NULL
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci
1 row in set (0.00 sec)

Check List

Tests

  • Unit test

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Sep 24, 2019
@codecov
Copy link

codecov bot commented Sep 24, 2019

Codecov Report

Merging #12327 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #12327   +/-   ##
===========================================
  Coverage   79.7595%   79.7595%           
===========================================
  Files           462        462           
  Lines        102216     102216           
===========================================
  Hits          81527      81527           
  Misses        14819      14819           
  Partials       5870       5870

@zz-jason
Copy link
Member

@tsthght Please follow the Commit Message and Pull Request Style to refactor the PR title.

@zz-jason
Copy link
Member

Also, please add a UT

@tsthght tsthght changed the title fix bug for #11831 executor: display of COLLATE is inconsistent with MySQL when executing show create table Sep 24, 2019
@tsthght tsthght changed the title executor: display of COLLATE is inconsistent with MySQL when executing show create table executor: fix inconsistent of column's display with MySQL when executing show create table Sep 24, 2019
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added component/DDL-need-LGT3 status/LGT1 Indicates that a PR has LGTM 1. labels Sep 25, 2019
@zz-jason zz-jason changed the title executor: fix inconsistent of column's display with MySQL when executing show create table executor: display column collate in show create table Sep 25, 2019
@zimulala zimulala added sig/execution SIG execution and removed component/DDL-need-LGT3 labels Sep 25, 2019
@zimulala
Copy link
Contributor

/run-all-tests

@zimulala
Copy link
Contributor

/rebuild

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala
Copy link
Contributor

/run-all-tests

@zimulala zimulala added status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 27, 2019
@zimulala zimulala added the status/LGT2 Indicates that a PR has LGTM 2. label Sep 27, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 27, 2019

/run-all-tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor. sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants