-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: display column collate in show create table
#12327
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12327 +/- ##
===========================================
Coverage 79.7595% 79.7595%
===========================================
Files 462 462
Lines 102216 102216
===========================================
Hits 81527 81527
Misses 14819 14819
Partials 5870 5870 |
@tsthght Please follow the Commit Message and Pull Request Style to refactor the PR title. |
Also, please add a UT |
COLLATE
is inconsistent with MySQL when executing show create table
COLLATE
is inconsistent with MySQL when executing show create table
show create table
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
show create table
show create table
/run-all-tests |
/rebuild |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
/run-all-tests |
What problem does this PR solve?
fix bug for #11831。should display collate of the column, but did not。
create table ttt4(a varchar(123) default null collate utf8mb4_unicode_ci)engine=innodb default charset=utf8mb4 collate=utf8mb4_unicode_ci;
show create table ttt4;
mysql> show create table ttt4\G
*************************** 1. row ***************************
Table: ttt4
Create Table: CREATE TABLE
ttt4
(a
varchar(123) DEFAULT NULL) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci
1 row in set (0.00 sec)
What is changed and how it works?
mysql> show create table ttt4\G
*************************** 1. row ***************************
Table: ttt4
Create Table: CREATE TABLE
ttt4
(a
varchar(123) COLLATE utf8mb4_unicode_ci DEFAULT NULL) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci
1 row in set (0.00 sec)
Check List
Tests