-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl : fix column collate should use table's if it has when create table or alter table. (#13119 & #12327) #13174
Conversation
/run-all-tests |
/run-common-test |
/run-integration-common-test |
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sorry @bb7133, you don't have permission to trigger auto merge event on this branch. |
cherry-pick #13119 and #12327 to release-3.0
What problem does this PR solve?
fix issue #13113
When creating a table, if we set a collate for this table, all columns in this table should use this collate instead of using default collates.
In MySQL:
In TiDB
What is changed and how it works?
Table's collate should be passed into
buildColumnsAndConstraints
when increate table or alter table
.Check List
Tests
Code changes
buildColumnsAndConstraints
function.Related changes
Release note