-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor,sessionctx: add correctness for system variables (#12311) #12587
executor,sessionctx: add correctness for system variables (#12311) #12587
Conversation
Hi @zz-jason This commit is going to cherry-pick a commit from master to release-3.0. Please help to review my code. Thanks, Ryan |
@xiaoronglv Sure! Thank you for the help! BTW, it's better to copy the original PR description to the cherry-picked PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sorry @qw4990, you don't have permission to trigger auto merge event on this branch. |
/merge |
/run-all-tests |
What problem does this PR solve?
For MySQL, thread_pool_size is the number of thread groups, which determine how many queries can execute simultaneously.
This commit is to add constraints for global variable thread_pool_size for TiDB, which is a subtask of epic Complete correctness for system.
What is changed and how it works?
Add restriction for global variable
thread_pool_size
, of whichCheck List
Tests
Code changes
Side effects