planner: correct unit test for outer join simplification with cast #12782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 17, 2019
|
/run-all-tests |
eurekaka
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for 12788, 12791, 12790 |
Codecov Report
@@ Coverage Diff @@
## master #12782 +/- ##
===========================================
Coverage 79.9907% 79.9907%
===========================================
Files 465 465
Lines 106256 106256
===========================================
Hits 84995 84995
Misses 14926 14926
Partials 6335 6335 |
|
/run-all-tests |
|
@eurekaka merge failed. |
|
/run-all-tests |
|
/build |
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
In #12701, we fixed a bug related to outer join simplification with cast function, and added a unit test for the fix. That unit test should have syntax error(which is not reported in current parser, this should be fixed later), so we fix the unit test in this PR.
What is changed and how it works?
Use another unit test for testing.
Check List
Tests
Code changes
N/A
Side effects
N/A
Related changes
N/A
Release note
N/A