Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner, expression: fix simplify outer join with cast (#12701) #12788

Merged
merged 3 commits into from
Oct 18, 2019

Conversation

eurekaka
Copy link
Contributor

cherry-pick #12701 and #12782

@eurekaka
Copy link
Contributor Author

/run-all-tests tidb-test=release-3.1 pd=release-3.1 tikv=release-3.1

Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@eurekaka eurekaka added the status/can-merge Indicates a PR has been approved by a committer. label Oct 17, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 17, 2019

/run-all-tests

@zz-jason zz-jason added the status/LGT2 Indicates that a PR has LGTM 2. label Oct 17, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 17, 2019

@eurekaka merge failed.

@eurekaka
Copy link
Contributor Author

/run-check_dev_2
/run-common-test tidb-test=release-3.1 pd=release-3.1 tikv=release-3.1

@ngaut
Copy link
Member

ngaut commented Oct 17, 2019

/run-all-tests

@ngaut ngaut merged commit 48ef539 into pingcap:release-3.1 Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants