-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: support a hint to force using a IndexMerge path #12843
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12843 +/- ##
================================================
+ Coverage 80.0403% 80.1242% +0.0839%
================================================
Files 474 474
Lines 116630 116695 +65
================================================
+ Hits 93351 93501 +150
+ Misses 15897 15805 -92
- Partials 7382 7389 +7 |
@eurekaka, it failed to add the test for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also generate hints for index merge in GenHintsFromPhysicalPlan
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I think we should update genHintsFromPhysicalPlan
for index merge hint as well, @lamxTyler please confirm.
--
Oh, I just noticed Haibin had already commented about it.
@eurekaka all the comments are fixed. |
@eurekaka all comments are fixed. |
@eurekaka all done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@eurekaka @lamxTyler this has been somedays. If it is ok, I can solve the conflict and push it again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please resolve the conflicts.
@eurekaka @lamxTyler it is finished. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
What problem does this PR solve?
Support a hint to access a table using IndexMerge way.
What is changed and how it works?
It is just like the other hints.
Check List
Tests
Code changes
Has exported function/method change
mainly change
func (ds *DataSource) accessPathsForConds
andfunc (ds *DataSource) DeriveStats
Has exported variable/fields change
tableHintInfo
adds theindexMergeHintList
field.Datasource
adds theindexMergeHint
field.Side effects
Possible performance regression
Breaking backward compatibility