Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util/printer: get GoVersion from runtime variable instead of shell #13763

Merged
merged 5 commits into from
Nov 27, 2019
Merged

util/printer: get GoVersion from runtime variable instead of shell #13763

merged 5 commits into from
Nov 27, 2019

Conversation

coocood
Copy link
Member

@coocood coocood commented Nov 27, 2019

What problem does this PR solve?

If we build tidb-server with a different go binary rather than the default go, the GoVersion may be wrong.

What is changed and how it works?

link runtime buildVersion variable in printer to get the GoVersion.

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    make server and run tidb-server -V

@coocood coocood requested review from jackysp and lysu November 27, 2019 02:22
@codecov
Copy link

codecov bot commented Nov 27, 2019 •
edited
Loading

Codecov Report

Merging #13763 into master will decrease coverage by 0.2973%.
The diff coverage is 50%.

@@               Coverage Diff                @@
##             master     #13763        +/-   ##
================================================
- Coverage   80.3674%   80.0701%   -0.2974%     
================================================
  Files           477        474         -3     
  Lines        119465     116599      -2866     
================================================
- Hits          96011      93361      -2650     
+ Misses        16071      15864       -207     
+ Partials       7383       7374         -9

lysu
lysu reviewed Nov 27, 2019
View reviewed changes
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and need gofmt

@lysu lysu added component/server status/LGT1 Indicates that a PR has LGTM 1. labels Nov 27, 2019
jackysp
jackysp approved these changes Nov 27, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 27, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 27, 2019

/run-all-tests

@sre-bot sre-bot merged commit 04fc7cc into pingcap:master Nov 27, 2019
qw4990 pushed a commit to qw4990/tidb that referenced this pull request Nov 27, 2019
@coocood @qw4990
util/printer: get GoVersion from runtime variable instead of shell (p…
49f4129 
…ingcap#13763)
@coocood coocood deleted the go-version branch November 27, 2019 07:21
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
@coocood @XiaTianliang
util/printer: get GoVersion from runtime variable instead of shell (p…
422821e 
…ingcap#13763)
@dveeden dveeden mentioned this pull request May 28, 2024
Merged
13 tasks
This was referenced Aug 20, 2024
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysu lysu lysu left review comments

@jackysp jackysp jackysp approved these changes

Assignees
No one assigned
Labels
component/server status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@coocood @sre-bot @lysu @jackysp