Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

session: add auto_increment_offset to global variables' loading list. #14388

Merged
merged 2 commits into from
Jan 8, 2020
Merged

session: add auto_increment_offset to global variables' loading list. #14388

merged 2 commits into from
Jan 8, 2020

Conversation

AilinKid
Copy link
Contributor

@AilinKid AilinKid commented Jan 8, 2020 •
edited
Loading

What problem does this PR solve?

It's left code by #14301
add auto_increment_offset to global variables' load.

What is changed and how it works?

add the variable name in builtinGlobalVariable.

Check List

Tests

  • Manual test (add detailed scripts or steps below)
  1. start a tidb server:
  2. set the global auto_increment_offset variable in one session.
  3. open a new session and show the global variable changed.

Related changes

  • Need to cherry-pick to the release branch

Release note

  • add auto_increment_offset to global variables' loading list.

lonng
lonng reviewed Jan 8, 2020
View reviewed changes
Copy link
Contributor

@lonng lonng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

djshow832
djshow832 reviewed Jan 8, 2020
View reviewed changes
Copy link
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AilinKid
Copy link
Contributor Author

AilinKid commented Jan 8, 2020

/run-unit-test

@AilinKid AilinKid added status/can-merge Indicates a PR has been approved by a committer. and removed status/can-merge Indicates a PR has been approved by a committer. labels Jan 8, 2020
@AilinKid
Copy link
Contributor Author

AilinKid commented Jan 8, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 8, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Jan 8, 2020

/run-all-tests

@sre-bot sre-bot merged commit e29873c into pingcap:master Jan 8, 2020
@AilinKid AilinKid mentioned this pull request Jan 8, 2020
Merged
AilinKid added a commit to AilinKid/tidb that referenced this pull request Jan 8, 2020
@AilinKid
session: add auto_increment_offset to global variables' loading list. (…
58ab800 
…pingcap#14388)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lonng lonng lonng left review comments

@djshow832 djshow832 djshow832 approved these changes

Assignees
No one assigned
Labels
status/can-merge Indicates a PR has been approved by a committer. type/new-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AilinKid @sre-bot @lonng @djshow832