Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: support auto_increment_increment & auto_increment_offset. (#14301) #14396

Merged
merged 4 commits into from
Jan 8, 2020
Merged

*: support auto_increment_increment & auto_increment_offset. (#14301) #14396

merged 4 commits into from
Jan 8, 2020

Conversation

AilinKid
Copy link
Contributor

@AilinKid AilinKid commented Jan 8, 2020 •
edited
Loading

What problem does this PR solve?

cherry-pick #14301 & #14388

conflict file

autoid: reduce the alloc type logic (dependency of autoRandom)
autoid_test: add a failpoint to allow big unsigned number rebase and allocate batch base on that. 
...: some parameter adjustment.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

Release note

@AilinKid
Copy link
Contributor Author

AilinKid commented Jan 8, 2020

/run-all-tests

@AilinKid
Copy link
Contributor Author

AilinKid commented Jan 8, 2020

/run-unit-test

djshow832
djshow832 reviewed Jan 8, 2020
View reviewed changes
Copy link
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reafans
Copy link
Contributor

reafans commented Jan 8, 2020

LGTM

@zimulala zimulala merged commit cd8fa79 into pingcap:release-3.0 Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djshow832 djshow832 djshow832 approved these changes

@wjhuang2016 wjhuang2016 Awaiting requested review from wjhuang2016

@bb7133 bb7133 Awaiting requested review from bb7133

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AilinKid @reafans @djshow832 @zimulala