executor, planner: ON DUPLICATE UPDATE can refer to un-project col #14412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winoros
added
type/compatibility
sig/planner
ghost
requested review from
eurekaka and
lzmhhh123
and removed request for
a team
jackysp
reviewed
Jan 9, 2020
| tk.MustExec("insert into b values(1, 2)") | ||
| tk.MustExec("insert into a select x from b ON DUPLICATE KEY UPDATE a.x=b.y") | ||
| c.Assert(tk.Se.AffectedRows(), Equals, uint64(2)) | ||
| tk.MustQuery("select * from a").Check(testkit.Rows("2")) |
There was a problem hiding this comment.
Could you add some tests about values() function?
eurekaka
reviewed
Jan 9, 2020
Co-authored-by: Kenan Yao <cauchy1992@gmail.com>
Closed
winoros
force-pushed
the
strange-mysql-comp
branch
from
2d522d2
to
f91eeae
Compare
lysu
previously approved these changes
Jan 6, 2021
|
/run-common-test |
|
/run-common-test |
|
/run-integration-common-test |
qw4990
approved these changes
Jan 6, 2021
|
/merge |
|
/run-all-tests |
|
@winoros merge failed. |
|
/run-unit-test |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jan 6, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jan 6, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: to fix #14164
What is changed and how it works?
What's Changed:
MySQL can get the column though it's not in the insert's SELECT stmt.
To solve this, i add the possible column to select's project result.
It's ugly in fact.
Related changes
Check List
Tests
Release note