Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor, planner: ON DUPLICATE UPDATE can refer to un-project col (#14412) #22233

Closed

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #14412 to release-4.0

What problem does this PR solve?

Issue Number: to fix #14164

What is changed and how it works?

What's Changed:

MySQL can get the column though it's not in the insert's SELECT stmt.
To solve this, i add the possible column to select's project result.
It's ugly in fact.

Related changes

  • planner/core

Check List

Tests

  • Unit test

Release note

  • ON DUPLICATE UPDATE can refer to un-project col

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

@ti-srebot: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 12, 2021
@tiancaiamao
Copy link
Contributor

Rejected in 4.0.16 bug triage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression do-not-merge/cherry-pick-not-approved needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/execution SIG execution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants