util, executor: use UnionRanges build index kv range for INLJ #15727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
SunRunAway and
eurekaka
and removed request for
a team
XuHuaiyu
added
priority/release-blocker
XuHuaiyu
force-pushed
the
issue15686
branch
2 times, most recently
from
05c57bf
to
13dd5bb
Compare
Codecov Report
@@ Coverage Diff @@
## master #15727 +/- ##
===========================================
Coverage 80.4907% 80.4907%
===========================================
Files 504 504
Lines 134608 134608
===========================================
Hits 108347 108347
Misses 17789 17789
Partials 8472 8472 |
Co-Authored-By: Kenan Yao <cauchy1992@gmail.com>
|
I cannot figure out why the old codes is wrong since the merge algo is the same. Can you create a issue for future opotimization? |
winoros
approved these changes
Mar 26, 2020
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
|
@XuHuaiyu merge failed. |
|
unit test failed because of #15594 |
XuHuaiyu
changed the title
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Mar 27, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-3.0 in PR #15753 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Mar 27, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-3.1 in PR #15754 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Mar 27, 2020
|
cherry pick to release-4.0 in PR #15756 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #15686
close #15693
close #15687
Problem Summary:
Before this commit, we build a wrong kv ranges which will cause data lost when index join fetchInnerResult.
What is changed and how it works?
What's Changed:
Use UnionRanges to merge ranges.
How it Works:
Related changes
Check List
Tests
Side effects
Release note