util, executor: use UnionRanges build index kv range for INLJ (#15727) #15754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
/run-all-tests |
sre-bot
added
sig/execution
XuHuaiyu
removed
the
priority/release-blocker
|
@SunRunAway, @eurekaka, @fzhedu, @winoros, PTAL. |
1 similar comment
|
@SunRunAway, @eurekaka, @fzhedu, @winoros, PTAL. |
fzhedu
reviewed
Apr 2, 2020
executor/join_test.go
Outdated
| @@ -906,7 +906,82 @@ func (s *testSuite2) TestIndexLookupJoin(c *C) { | |||
| tk.MustQuery("select /*+ TIDB_INLJ(s) */ count(*) from t join s use index(idx) on s.a = t.a and s.b < t.b").Check(testkit.Rows("64")) | |||
| } | |||
|
|
|||
| <<<<<<< HEAD | |||
There was a problem hiding this comment.
please address conflicts @XuHuaiyu
…e-bot/release-3.1-15c3b74ca934
|
@fzhedu, @SunRunAway, @eurekaka, @winoros, PTAL. |
2 similar comments
|
@fzhedu, @SunRunAway, @eurekaka, @winoros, PTAL. |
|
@fzhedu, @SunRunAway, @eurekaka, @winoros, PTAL. |
|
/run-all-tests |
|
@zz-jason |
zz-jason
added
status/can-merge
|
Your auto merge job has been accepted, waiting for 15753 |
|
/run-all-tests |
|
@sre-bot merge failed. |
|
/run-integration-common-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #15727 to release-3.1
What problem does this PR solve?
Issue Number: close #15686
close #15693
close #15687
Problem Summary:
Before this commit, we build a wrong kv ranges which will cause data lost when index join fetchInnerResult.
What is changed and how it works?
What's Changed:
Use UnionRanges to merge ranges.
How it Works:
Related changes
Check List
Tests
Side effects
Release note