config: move storage check after initializeTempDir #16257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yisaer
commented
Apr 9, 2020
Comment on lines
-875
to
-877
| } else if capacityByte > uint64(c.TempStorageQuota) { | ||
| return fmt.Errorf("value of [temp-storage-quota](%d byte) exceeds the capacity(%d byte) of the [%s] directory", c.TempStorageQuota, capacityByte, c.TempStoragePath) | ||
| } |
There was a problem hiding this comment.
The original logic here is wrong, I correct it in this request.
Codecov Report
@@ Coverage Diff @@
## master #16257 +/- ##
===========================================
Coverage 80.4897% 80.4897%
===========================================
Files 506 506
Lines 137446 137446
===========================================
Hits 110630 110630
Misses 18305 18305
Partials 8511 8511 |
qw4990
added
status/can-merge
|
/run-all-tests |
|
@Yisaer merge failed. |
|
/run-all-tests |
|
/run-unit-test |
|
/run-integration-copr-test |
|
@Yisaer Please cherry-pick this commit to release-4.0 |
|
/run-cherry-picker |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Apr 16, 2020
|
cherry pick to release-4.0 in PR #16462 |
SunRunAway
pushed a commit
that referenced
this pull request
Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Move storage check after initializeTempDir so that avoiding the capacity we get is smaller than the fact.
Related changes
Release note
None