Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: move storage check after initializeTempDir (#16257) #16462

Merged
merged 5 commits into from
Apr 21, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 16, 2020

cherry-pick #16257 to release-4.0


What problem does this PR solve?

Move storage check after initializeTempDir so that avoiding the capacity we get is smaller than the fact.

Related changes

  • Need to cherry-pick to the release branch

Release note

None

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 16, 2020

/run-all-tests

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@Yisaer
Copy link
Contributor

Yisaer commented Apr 20, 2020

/run-all-tests

@Yisaer
Copy link
Contributor

Yisaer commented Apr 20, 2020

/run-unit-test

@Yisaer
Copy link
Contributor

Yisaer commented Apr 20, 2020

/run-sqllogic-test-2

@Yisaer
Copy link
Contributor

Yisaer commented Apr 20, 2020

/run-all-tests

2 similar comments
@Yisaer
Copy link
Contributor

Yisaer commented Apr 20, 2020

/run-all-tests

@Yisaer
Copy link
Contributor

Yisaer commented Apr 21, 2020

/run-all-tests

@Yisaer
Copy link
Contributor

Yisaer commented Apr 21, 2020

/run-check_dev

@Yisaer
Copy link
Contributor

Yisaer commented Apr 21, 2020

/run-all-tests

@Yisaer
Copy link
Contributor

Yisaer commented Apr 21, 2020

/run-check_dev

@Yisaer

This comment has been minimized.

1 similar comment
@Yisaer
Copy link
Contributor

Yisaer commented Apr 21, 2020

/run-integration-copr-test

@SunRunAway SunRunAway added status/all-tests-passed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 21, 2020
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway SunRunAway merged commit 5b3fcb7 into pingcap:release-4.0 Apr 21, 2020
@SunRunAway SunRunAway added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants