Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: cannot simply outer join if a predicate just refers to the outer table #16444

Merged
merged 3 commits into from
Apr 16, 2020

Conversation

fzhedu
Copy link
Contributor

@fzhedu fzhedu commented Apr 15, 2020

What problem does this PR solve?

Issue Number: close #16023

Problem Summary:
Simplying the outer join with predicates shoud not take a predicate which only refers to the outer table

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

Release note

@fzhedu fzhedu requested review from eurekaka and winoros April 15, 2020 15:43
@fzhedu fzhedu requested a review from a team as a code owner April 15, 2020 15:43
@ghost ghost removed their request for review April 15, 2020 15:44
@fzhedu fzhedu requested review from francis0407 and a team April 15, 2020 15:44
@ghost ghost removed their request for review April 15, 2020 15:44
@codecov
Copy link

codecov bot commented Apr 15, 2020

Codecov Report

Merging #16444 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #16444   +/-   ##
===========================================
  Coverage   80.4354%   80.4354%           
===========================================
  Files           506        506           
  Lines        136701     136701           
===========================================
  Hits         109956     109956           
  Misses        18185      18185           
  Partials       8560       8560           

Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XuHuaiyu XuHuaiyu changed the title BugFix 16023: cannot simply outer join if a predicate just refers to the outer table planner: cannot simply outer join if a predicate just refers to the outer table Apr 16, 2020
@XuHuaiyu
Copy link
Contributor

Please add some labels for this PR.

@fzhedu fzhedu added sig/planner SIG: Planner needs-cherry-pick-2.1 type/bugfix This PR fixes a bug. labels Apr 16, 2020
@fzhedu fzhedu requested a review from XuHuaiyu April 16, 2020 03:54
@fzhedu
Copy link
Contributor Author

fzhedu commented Apr 16, 2020

Please add some labels for this PR.

Done

Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XuHuaiyu
Copy link
Contributor

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 16, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 16, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Apr 16, 2020

@fzhedu merge failed.

@fzhedu
Copy link
Contributor Author

fzhedu commented Apr 16, 2020

/run-integration-copr-test

@fzhedu
Copy link
Contributor Author

fzhedu commented Apr 16, 2020

/run-integration-{copr}-test

@fzhedu
Copy link
Contributor Author

fzhedu commented Apr 16, 2020

/run-all-tests

@fzhedu
Copy link
Contributor Author

fzhedu commented Apr 16, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Apr 16, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Apr 16, 2020

@fzhedu merge failed.

@fzhedu
Copy link
Contributor Author

fzhedu commented Apr 16, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Apr 16, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Apr 16, 2020

@fzhedu merge failed.

@fzhedu
Copy link
Contributor Author

fzhedu commented Apr 16, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Apr 16, 2020

/run-all-tests

@sre-bot sre-bot merged commit e3b635e into pingcap:master Apr 16, 2020
@fzhedu
Copy link
Contributor Author

fzhedu commented Apr 16, 2020

/run-cherry-picker

sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Apr 16, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Apr 16, 2020

cherry pick to release-2.1 in PR #16491

sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Apr 16, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Apr 16, 2020

cherry pick to release-3.0 in PR #16492

sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Apr 16, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Apr 16, 2020

cherry pick to release-3.1 in PR #16493

@sre-bot
Copy link
Contributor

sre-bot commented Apr 16, 2020

cherry pick to release-4.0 in PR #16494

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RIGHT JOIN with CONCAT_WS fails to fetch a row
4 participants