Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: cannot simply outer join if a predicate just refers to the outer table (#16444) #16494

Merged
merged 2 commits into from
Apr 20, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 16, 2020

cherry-pick #16444 to release-4.0


What problem does this PR solve?

Issue Number: close #16023

Problem Summary:
Simplying the outer join with predicates shoud not take a predicate which only refers to the outer table

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

Release note

@sre-bot sre-bot requested a review from a team as a code owner April 16, 2020 14:31
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 16, 2020

/run-all-tests

Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XuHuaiyu
Copy link
Contributor

/rebuild

@SunRunAway SunRunAway added status/all-tests-passed status/can-merge Indicates a PR has been approved by a committer. labels Apr 20, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 20, 2020

/run-all-tests

Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sre-bot sre-bot merged commit 834f247 into pingcap:release-4.0 Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants